tk/spectre.console
1
0
Fork 0
mirror of https://github.com/nsnail/spectre.console.git synced 2025-11-01 01:25:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Fixed render issue where writeline inside status caused corrupt output #415 #694"

Browse Source 
This reverts commit 71a5d83067.

The commit introduced major flickering when working with LiveRenderables

Fixes #1466
This commit is contained in:
Phil Scott
2024-04-01 11:36:38 -04:00
committed by Patrik Svensson
parent 1a3249cdae
commit fc0b553a4a
4 changed files with 3 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Spectre.Console/Live/LiveRenderable.cs
View File

@@ -49,7 +49,7 @@ internal sealed class LiveRenderable : Renderable
}
var linesToMoveUp = _shape.Value.Height - 1;
return new ControlCode("\r" + (EL(2) + CUU(1)).Repeat(linesToMoveUp));
return new ControlCode("\r" + CUU(linesToMoveUp));
}
}

4
test/Spectre.Console.Tests/Expectations/Live/Status/Render.Output.verified.txt
View File

@@ -1,10 +1,10 @@
[?25l
* foo


- bar


* baz
[?25h

12
test/Spectre.Console.Tests/Expectations/Live/Status/WriteLineOverflow.Output.verified.txt
View File

@@ -1,12 +0,0 @@
[?25l
⣷ long text that should not interfere writeline text
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
xxxxxxxxxx
⣷ long text that should not interfere writeline text

⣷ long text that should not interfere writeline text
[?25h

26
test/Spectre.Console.Tests/Unit/Live/StatusTests.cs
View File

@@ -48,30 +48,4 @@ public sealed class StatusTests
// Then
return Verifier.Verify(console.Output);
}
[Fact]
[Expectation("WriteLineOverflow")]
public Task Should_Render_Correctly_When_WriteLine_Exceeds_Console_Width()
{
// Given
var console = new TestConsole()
.Colors(ColorSystem.TrueColor)
.Width(100)
.Interactive()
.EmitAnsiSequences();
var status = new Status(console)
{
AutoRefresh = false,
};
// When
status.Start("long text that should not interfere writeline text", ctx =>
{
ctx.Refresh();
console.WriteLine("x".Repeat(console.Profile.Width + 10), new Style(foreground: Color.White));
});
// Then
return Verifier.Verify(console.Output);
}
}