mirror of
				https://github.com/nsnail/spectre.console.git
				synced 2025-10-31 09:09:25 +08:00 
			
		
		
		
	Make tests run on .NET Framework 4.8
Since Spectre.Console targets .NET Standard 2.0 it makes sense to also run tests on .NET Framework (Windows only)
This makes two tests fail: `Should_Write_Exception_With_Inner_Exception` and `Should_Write_Exceptions_With_Generic_Type_Parameters_In_Callsite_As_Expected`.
Received (inner exception not handled):
```
System.InvalidOperationException: Something threw!System.InvalidOperationException: Throwing!
  at Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(Nullable`1 number) in /xyz/Exceptions.cs:nn
  at Spectre.Console.Tests.Data.TestExceptions.ThrowWithInnerException() in /xyz/Exceptions.cs:nn
```
Verified:
```
System.InvalidOperationException: Something threw!
     System.InvalidOperationException: Throwing!
       at Spectre.Console.Tests.Data.TestExceptions.MethodThatThrows(Nullable`1 number) in /xyz/Exceptions.cs:nn
       at Spectre.Console.Tests.Data.TestExceptions.ThrowWithInnerException() in /xyz/Exceptions.cs:nn
  at Spectre.Console.Tests.Data.TestExceptions.ThrowWithInnerException() in /xyz/Exceptions.cs:nn
  at Spectre.Console.Tests.Unit.ExceptionTests.<>c.<Should_Write_Exception_With_Inner_Exception>b__3_0() in /xyz/ExceptionTests.cs:nn
  at Spectre.Console.Tests.Unit.ExceptionTests.GetException(Action action) in /xyz/ExceptionTests.cs:nn
```
			
			
This commit is contained in:
		 Cédric Luthi
					Cédric Luthi
				
			
				
					committed by
					
						 Patrik Svensson
						Patrik Svensson
					
				
			
			
				
	
			
			
			 Patrik Svensson
						Patrik Svensson
					
				
			
						parent
						
							3c5b98123b
						
					
				
				
					commit
					bf95564ebb
				
			| @@ -1,7 +1,9 @@ | ||||
| <Project Sdk="Microsoft.NET.Sdk"> | ||||
|  | ||||
|   <PropertyGroup> | ||||
|     <TargetFrameworks>net5.0</TargetFrameworks> | ||||
|     <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('Windows'))">net5.0;net48</TargetFrameworks> | ||||
|     <TargetFramework Condition="!$([MSBuild]::IsOSPlatform('Windows'))">net5.0</TargetFramework> | ||||
|     <LangVersion>9.0</LangVersion> | ||||
|   </PropertyGroup> | ||||
|  | ||||
|   <ItemGroup> | ||||
| @@ -17,10 +19,12 @@ | ||||
|   </ItemGroup> | ||||
|  | ||||
|   <ItemGroup> | ||||
|     <PackageReference Include="IsExternalInit" Version="1.0.1" PrivateAssets="all" /> | ||||
|     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnit" Version="1.1.0" /> | ||||
|     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing.XUnit" Version="1.1.0" /> | ||||
|     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="2.6.1" /> | ||||
|     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" /> | ||||
|     <PackageReference Include="Nullable" Version="1.3.0" PrivateAssets="all" /> | ||||
|     <PackageReference Include="Shouldly" Version="4.0.3" /> | ||||
|     <PackageReference Include="Spectre.Verify.Extensions" Version="0.3.0" /> | ||||
|     <PackageReference Include="Verify.Xunit" Version="9.0.0-beta.1" /> | ||||
|   | ||||
| @@ -12,4 +12,14 @@ namespace Spectre.Console.Tests | ||||
|             VerifierSettings.DerivePathInfo(Expectations.Initialize); | ||||
|         } | ||||
|     } | ||||
| } | ||||
| } | ||||
|  | ||||
| #if !NET5_0_OR_GREATER | ||||
| namespace System.Runtime.CompilerServices | ||||
| { | ||||
|     [AttributeUsage(AttributeTargets.Method, Inherited = false)] | ||||
|     public sealed class ModuleInitializerAttribute : Attribute | ||||
|     { | ||||
|     } | ||||
| } | ||||
| #endif | ||||
|   | ||||
		Reference in New Issue
	
	Block a user