Hi,
The sentence wasn't on the same indentation level. I was surprised when reading the sentence in the doc. Here is my little help on that :)
Thank you for your work on this project
J
* updated dotnet core sdk and cake build script
* update travis SDK version
* update mono for travis and update .net core sdk to what appveyor supports
* same version of .net in travis as cake build
* same sdk on traivs and appveyor
The two singletons registered for IDownstreamRouteProvider,
DownstreamRouteFinder and DownstreamRouteCreator, were registered using
`TryAddSingleton`. This would cause DownstreamRouteFinder to be
instantiated and found but the "Try" made DownstreamRouteCreator not
registered.
This was noted in the following in `DownstreamRouteProviderFactory`:
```
_providers = provider.GetServices<IDownstreamRouteProvider>().ToDictionary(x => x.GetType().Name);
```
With the registration being done using `TryAddSingleton` only one
element was added to the dictionary. Changing this to `AddSingleton`
fixed this issue.
This was uncovered in an error on line 30 of
`DownstreamRouteProviderFactory`. The key for
`nameof(DownstreamRouteCreator)` did not exist causing an exception to
be thrown.
Ocelot websocket middleware did not work for STOMP over websocket. After investigation i found out that the issue was with subprotocol and headers that are send and filtered.
I the end i used ASP.Net core proxy as a reference to solve the issue here:
3015029f51/src/Microsoft.AspNetCore.Proxy/ProxyAdvancedExtensions.cs
So i modified the code to use the way ASP.Net proxy handles this.
* #630 only set status code if response hasnt started, otherwise exception
* #623 made {RemoteIpAddress} available as placeholder so you can do x-forwarded-for
* #623 local address different on mac, windows and linux for integration test
* renamed some middlewares so they make more sense
* add downstreamroutefindermiddleware benchmark
* #630 only set status code if response hasnt started, otherwise exception
* #623 made {RemoteIpAddress} available as placeholder so you can do x-forwarded-for
* #623 local address different on mac, windows and linux for integration test
* tidy up some code so I can understand it
* broke al the things that make config out into their own classes etc..sigh
* fix the things i broked
* #597 test for issue, works on this branch :E
* #597 removed comments
* added tests for new load balancer creator..basic
* added tests for lb creator and aggregates creator
* added tests for config creator
* boiler plate for tests
* added dynamics tests
* wip
* finished refactoring for now
* started refactoring json config validation stack because ive made it crap
* inject validators from DI rather than instanciating, next step mock them
* added some unit tests for specific validators on the train yey
* #574 consolidate some code, man the config stuff is a mess!
* #574 just use the downstream re route and the key for caching http clients
* #574 added benchmark, i was suprised to learn using a complex type was faster than a string in benchmark .net dictionary tests, hey ho probably dont have enough data in the type...
* #580 added failing test
* #580 added failing test for dynamic reroutes
* #580 added failing test for validator
* #580 validation tests passing
* #580 acceptance tests passing
* #580 got rid of the list in sdp factory
* +semver: breaking #580 service discovery provider returned by delegate must be the same as name in config, this is a breaking change because you have to specify consul now
* #580 removed use servide discovery property from file config, we dont need it, just use the service name as indicator the user wants to use service discovery for the given reroute
* #568 worked out how to check if qos handler present and kill Ocelot if options specified but no handler, need to refactor this into fluent validation style
* #568 acceptance tests to make sure Ocelot won't start if the user specifies QoSOptions but doesnt have a QoSHandler registered
* #568 Ocelot wont start if QoSOptions specified and no QoS DelegatingHandler registered e.g. no use of Ocelot.Provider.Polly. Also adds a NoQosDelegatingHandler and logs an error if ive missed something and the user can get to making the request
* #568 sadly something wierd with IServiceProvider and FluentValidation so I'm just defaulting to warning and noqosdelegatinghandler if someone doesnt register but provides options, also added basic in memory cache in case people dont use a specific package
* #555 added some tests for this issue but struggling to replicate
* #555 removed cmd=instance from service fabric code as someone who knows service fabric says its not needed
I
* #555 renamed test
* added delegate to select last handler
* #529 implemented a way we can inject the last delegating handler
* wip - moving code
* #529 removed loads of qos code and moved it into Ocelot.Provider.Polly
* #529 can now inject http client expcetions to ocelot errors mappers and updated docs
* added delegate to select last handler
* #529 implemented a way we can inject the last delegating handler
* wip - moving code
* #529 removed loads of qos code and moved it into Ocelot.Provider.Polly
