tk/spectre.console
1
0
Fork 0
mirror of https://github.com/nsnail/spectre.console.git synced 2025-06-16 12:13:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add strict parsing to all version tests, an obvious omission in main

Browse Source
This commit is contained in:
Frank Ray 2024-10-11 17:27:35 +01:00 committed by Patrik Svensson
parent e9f9f56189
commit 2f8a38f169
1 changed files with 77 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
src/Tests/Spectre.Console.Cli.Tests/Unit/CommandAppTests.Version.cs
View File

@ -4,11 +4,17 @@ public sealed partial class CommandAppTests
{ {
public sealed class Version public sealed class Version
{ {
[Fact] [Theory]
public void Should_Output_CLI_Version_To_The_Console() [InlineData(false)]
[InlineData(true)]
public void Should_Output_CLI_Version_To_The_Console(bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator =>
{
configurator.Settings.StrictParsing = strictParsing;
});
// When // When
var result = fixture.Run(Constants.VersionCommand); var result = fixture.Run(Constants.VersionCommand);
@ -18,14 +24,17 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Output_Application_Version_To_The_Console_With_No_Command(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Output_Application_Version_To_The_Console_With_No_Command(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
}); });
@ -37,12 +46,18 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Not_Display_Version_If_Not_Specified(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Not_Display_Version_If_Not_Specified(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator =>
{
configurator.Settings.StrictParsing = strictParsing;
});
// When // When
var result = fixture.Run(versionOption); var result = fixture.Run(versionOption);
@ -53,15 +68,18 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Output_Application_Version_To_The_Console_With_Default_Command(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Output_Application_Version_To_The_Console_With_Default_Command(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.SetDefaultCommand<EmptyCommand>(); fixture.SetDefaultCommand<EmptyCommand>();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
}); });
@ -73,14 +91,17 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Execute_Command_Not_Output_Application_Version_To_The_Console(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Execute_Command_Not_Output_Application_Version_To_The_Console(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
configurator.AddCommand<EmptyCommand>("empty"); configurator.AddCommand<EmptyCommand>("empty");
}); });
@ -94,14 +115,17 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Output_Application_Version_To_The_Console_With_Branch_Default_Command(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Output_Application_Version_To_The_Console_With_Branch_Default_Command(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
configurator.AddBranch<EmptyCommandSettings>("branch", branch => configurator.AddBranch<EmptyCommandSettings>("branch", branch =>
{ {
@ -117,14 +141,17 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Execute_Branch_Default_Command_Not_Output_Application_Version_To_The_Console(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Execute_Branch_Default_Command_Not_Output_Application_Version_To_The_Console(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
configurator.AddBranch<EmptyCommandSettings>("branch", branch => configurator.AddBranch<EmptyCommandSettings>("branch", branch =>
{ {
@ -141,14 +168,17 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Execute_Branch_Command_Not_Output_Application_Version_To_The_Console(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Execute_Branch_Command_Not_Output_Application_Version_To_The_Console(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
configurator.AddBranch<EmptyCommandSettings>("branch", branch => configurator.AddBranch<EmptyCommandSettings>("branch", branch =>
{ {
@ -169,15 +199,18 @@ public sealed partial class CommandAppTests
/// then execute this command instead of displaying the explicitly set Application Version. /// then execute this command instead of displaying the explicitly set Application Version.
/// </summary> /// </summary>
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Execute_Default_VersionCommand_Not_Output_Application_Version_To_The_Console(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Execute_Default_VersionCommand_Not_Output_Application_Version_To_The_Console(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.SetDefaultCommand<Spectre.Console.Tests.Data.VersionCommand>(); fixture.SetDefaultCommand<Spectre.Console.Tests.Data.VersionCommand>();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
}); });
@ -189,14 +222,17 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Execute_VersionCommand_Not_Output_Application_Version_To_The_Console(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Execute_VersionCommand_Not_Output_Application_Version_To_The_Console(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
configurator.AddCommand<Spectre.Console.Tests.Data.VersionCommand>("hello"); configurator.AddCommand<Spectre.Console.Tests.Data.VersionCommand>("hello");
}); });
@ -209,14 +245,17 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Execute_Branch_Default_VersionCommand_Not_Output_Application_Version_To_The_Console(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Execute_Branch_Default_VersionCommand_Not_Output_Application_Version_To_The_Console(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
configurator.AddBranch<VersionSettings>("branch", branch => configurator.AddBranch<VersionSettings>("branch", branch =>
{ {
@ -232,14 +271,17 @@ public sealed partial class CommandAppTests
} }
[Theory] [Theory]
[InlineData("-v")] [InlineData("-v", false)]
[InlineData("--version")] [InlineData("-v", true)]
public void Should_Execute_Branch_VersionCommand_Not_Output_Application_Version_To_The_Console(string versionOption) [InlineData("--version", false)]
[InlineData("--version", true)]
public void Should_Execute_Branch_VersionCommand_Not_Output_Application_Version_To_The_Console(string versionOption, bool strictParsing)
{ {
// Given // Given
var fixture = new CommandAppTester(); var fixture = new CommandAppTester();
fixture.Configure(configurator => fixture.Configure(configurator =>
{ {
configurator.Settings.StrictParsing = strictParsing;
configurator.SetApplicationVersion("1.0"); configurator.SetApplicationVersion("1.0");
configurator.AddBranch<VersionSettings>("branch", branch => configurator.AddBranch<VersionSettings>("branch", branch =>
{ {