tk/spectre.console
1
0
Fork 0
mirror of https://github.com/nsnail/spectre.console.git synced 2025-04-16 08:52:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary [NotNull] attributes

Browse Source 
When subclassing `Command<TSettings>` which has the [NotNull] attributes, Rider/ReSharper gives this warning:
> Nullability of type of parameter 'context' in method does not match overridden member `int Spectre.Console.Cli.Command<TSettings>.Execute(CommandContext, TSettings)` (possibly because of nullability attributes)

When subclassing `Command<TSettings>` which does not have the [NotNull] attributes, Rider/ReSharper gives this warning:
> The nullability attribute has no effect and can be safely removed

The solution is simply to remove the [NotNull] attributes.

Since `<Nullable>enable</Nullable>` is set in the project, they are actually not necessary. By the way, the non-generic `Command` class does not have the [NotNull] attributes.
This commit is contained in:
Cédric Luthi 2023-07-12 14:15:41 +02:00 committed by Patrik Svensson
parent 83afa97017
commit 2af901a814
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Spectre.Console.Cli/CommandOfT.cs
View File

@ -14,7 +14,7 @@ public abstract class Command<TSettings> : ICommand<TSettings>
/// <param name="context">The command context.</param> /// <param name="context">The command context.</param>
/// <param name="settings">The settings.</param> /// <param name="settings">The settings.</param>
/// <returns>The validation result.</returns> /// <returns>The validation result.</returns>
public virtual ValidationResult Validate([NotNull] CommandContext context, [NotNull] TSettings settings) public virtual ValidationResult Validate(CommandContext context, TSettings settings)
{ {
return ValidationResult.Success(); return ValidationResult.Success();
} }
@ -25,7 +25,7 @@ public abstract class Command<TSettings> : ICommand<TSettings>
/// <param name="context">The command context.</param> /// <param name="context">The command context.</param>
/// <param name="settings">The settings.</param> /// <param name="settings">The settings.</param>
/// <returns>An integer indicating whether or not the command executed successfully.</returns> /// <returns>An integer indicating whether or not the command executed successfully.</returns>
public abstract int Execute([NotNull] CommandContext context, [NotNull] TSettings settings); public abstract int Execute(CommandContext context, TSettings settings);
/// <inheritdoc/> /// <inheritdoc/>
ValidationResult ICommand.Validate(CommandContext context, CommandSettings settings) ValidationResult ICommand.Validate(CommandContext context, CommandSettings settings)

2
src/Spectre.Console.Cli/Internal/Commands/ExplainCommand.cs
View File

@ -34,7 +34,7 @@ internal sealed class ExplainCommand : Command<ExplainCommand.Settings>
public bool IncludeHidden { get; } public bool IncludeHidden { get; }
} }
public override int Execute([NotNull] CommandContext context, [NotNull] Settings settings) public override int Execute(CommandContext context, Settings settings)
{ {
var tree = new Tree("CLI Configuration"); var tree = new Tree("CLI Configuration");
tree.AddNode(ValueMarkup("Application Name", _commandModel.ApplicationName, "no application name")); tree.AddNode(ValueMarkup("Application Name", _commandModel.ApplicationName, "no application name"));

2
src/Spectre.Console.Cli/Internal/Commands/VersionCommand.cs
View File

@ -15,7 +15,7 @@ internal sealed class VersionCommand : Command<VersionCommand.Settings>
{ {
} }
public override int Execute([NotNull] CommandContext context, [NotNull] Settings settings) public override int Execute(CommandContext context, Settings settings)
{ {
_writer.MarkupLine( _writer.MarkupLine(
"[yellow]Spectre.Cli[/] version [aqua]{0}[/]", "[yellow]Spectre.Cli[/] version [aqua]{0}[/]",

2
src/Spectre.Console.Cli/Internal/Commands/XmlDocCommand.cs
View File

@ -17,7 +17,7 @@ internal sealed class XmlDocCommand : Command<XmlDocCommand.Settings>
{ {
} }
public override int Execute([NotNull] CommandContext context, [NotNull] Settings settings) public override int Execute(CommandContext context, Settings settings)
{ {
_writer.Write(Serialize(_model), Style.Plain); _writer.Write(Serialize(_model), Style.Plain);
return 0; return 0;

2
test/Spectre.Console.Cli.Tests/Data/Commands/GreeterCommand.cs
View File

@ -9,7 +9,7 @@ public class GreeterCommand : Command<OptionalArgumentWithDefaultValueSettings>
_console = console; _console = console;
} }
public override int Execute([NotNull] CommandContext context, [NotNull] OptionalArgumentWithDefaultValueSettings settings) public override int Execute(CommandContext context, OptionalArgumentWithDefaultValueSettings settings)
{ {
_console.WriteLine(settings.Greeting); _console.WriteLine(settings.Greeting);
return 0; return 0;