From 19eb273813e14988fd5a5af3f1b4df83b7dca89b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Luthi?= <cedric.luthi@gmail.com>
Date: Wed, 10 Nov 2021 14:16:58 +0100
Subject: [PATCH] Fix typo in PairDeconstructor class name
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PairDeconstuctor → PairDeconstructor (was missing an 'r')

Keeping `PairDeconstuctor` and marking it as obsolete since it's a public type.
---
 .../Cli/Internal/Modelling/CommandParameter.cs      |  4 ++--
 .../{PairDeconstuctor.cs => PairDeconstructor.cs}   | 13 ++++++++++++-
 .../Unit/Cli/CommandAppTests.Pairs.cs               |  2 +-
 3 files changed, 15 insertions(+), 4 deletions(-)
 rename src/Spectre.Console/Cli/{PairDeconstuctor.cs => PairDeconstructor.cs} (65%)

diff --git a/src/Spectre.Console/Cli/Internal/Modelling/CommandParameter.cs b/src/Spectre.Console/Cli/Internal/Modelling/CommandParameter.cs
index d99e4d1..8f62f8f 100644
--- a/src/Spectre.Console/Cli/Internal/Modelling/CommandParameter.cs
+++ b/src/Spectre.Console/Cli/Internal/Modelling/CommandParameter.cs
@@ -28,7 +28,7 @@ namespace Spectre.Console.Cli
             Type parameterType, ParameterKind parameterKind, PropertyInfo property,
             string? description, TypeConverterAttribute? converter,
             DefaultValueAttribute? defaultValue,
-            PairDeconstructorAttribute? deconstuctor,
+            PairDeconstructorAttribute? deconstructor,
             ParameterValueProviderAttribute? valueProvider,
             IEnumerable<ParameterValidationAttribute> validators, bool required)
         {
@@ -39,7 +39,7 @@ namespace Spectre.Console.Cli
             Description = description;
             Converter = converter;
             DefaultValue = defaultValue;
-            PairDeconstructor = deconstuctor;
+            PairDeconstructor = deconstructor;
             ValueProvider = valueProvider;
             Validators = new List<ParameterValidationAttribute>(validators ?? Array.Empty<ParameterValidationAttribute>());
             Required = required;
diff --git a/src/Spectre.Console/Cli/PairDeconstuctor.cs b/src/Spectre.Console/Cli/PairDeconstructor.cs
similarity index 65%
rename from src/Spectre.Console/Cli/PairDeconstuctor.cs
rename to src/Spectre.Console/Cli/PairDeconstructor.cs
index efb49cd..163a85a 100644
--- a/src/Spectre.Console/Cli/PairDeconstuctor.cs
+++ b/src/Spectre.Console/Cli/PairDeconstructor.cs
@@ -7,7 +7,7 @@ namespace Spectre.Console.Cli
     /// </summary>
     /// <typeparam name="TKey">The key type.</typeparam>
     /// <typeparam name="TValue">The value type.</typeparam>
-    public abstract class PairDeconstuctor<TKey, TValue> : IPairDeconstructor
+    public abstract class PairDeconstructor<TKey, TValue> : IPairDeconstructor
     {
         /// <summary>
         /// Deconstructs the provided <see cref="string"/> into a pair.
@@ -27,4 +27,15 @@ namespace Spectre.Console.Cli
             return Deconstruct(value);
         }
     }
+
+    /// <summary>
+    /// Base class for a pair deconstructor.
+    /// </summary>
+    /// <typeparam name="TKey">The key type.</typeparam>
+    /// <typeparam name="TValue">The value type.</typeparam>
+    /// <remarks>This class is misspelled, use <see cref="PairDeconstructor{TKey,TValue}"/> instead.</remarks>
+    [Obsolete("Use PairDeconstructor instead")]
+    public abstract class PairDeconstuctor<TKey, TValue> : PairDeconstructor<TKey, TValue>
+    {
+    }
 }
diff --git a/test/Spectre.Console.Tests/Unit/Cli/CommandAppTests.Pairs.cs b/test/Spectre.Console.Tests/Unit/Cli/CommandAppTests.Pairs.cs
index ea1565d..bf47e96 100644
--- a/test/Spectre.Console.Tests/Unit/Cli/CommandAppTests.Pairs.cs
+++ b/test/Spectre.Console.Tests/Unit/Cli/CommandAppTests.Pairs.cs
@@ -56,7 +56,7 @@ namespace Spectre.Console.Tests.Unit.Cli
                 public IReadOnlyDictionary<string, string> Values { get; set; }
             }
 
-            public sealed class StringIntDeconstructor : PairDeconstuctor<string, string>
+            public sealed class StringIntDeconstructor : PairDeconstructor<string, string>
             {
                 protected override (string Key, string Value) Deconstruct(string value)
                 {