tk/spectre.console
1
0
Fork 0
mirror of https://github.com/nsnail/spectre.console.git synced 2025-04-16 17:02:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Adds additional check that analyzer is within a method

Browse Source 
Resolve #487
This commit is contained in:
Phil Scott 2021-07-13 19:22:05 -04:00 committed by Patrik Svensson
parent c2b25eea8a
commit 170901f584
2 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Spectre.Console.Analyzer/Analyzers/FavorInstanceAnsiConsoleOverStaticAnalyzer.cs
View File

@ -37,6 +37,12 @@ namespace Spectre.Console.Analyzer
return; return;
} }
// if we aren't in a method then it might be too complex for us to handle.
if (!invocationOperation.Syntax.Ancestors().OfType<MethodDeclarationSyntax>().Any())
{
return;
}
if (!HasFieldAnsiConsole(invocationOperation.Syntax) && if (!HasFieldAnsiConsole(invocationOperation.Syntax) &&
!HasParameterAnsiConsole(invocationOperation.Syntax)) !HasParameterAnsiConsole(invocationOperation.Syntax))
{ {

22
test/Spectre.Console.Analyzer.Tests/Unit/Analyzers/UseInstanceAnsiConsoleTests.cs
View File

@ -10,6 +10,28 @@ namespace Spectre.Console.Analyzer.Tests.Unit.Analyzers
Descriptors.S1010_FavorInstanceAnsiConsoleOverStatic.Id, Descriptors.S1010_FavorInstanceAnsiConsoleOverStatic.Id,
DiagnosticSeverity.Info); DiagnosticSeverity.Info);
[Fact]
public async void Should_only_warn_within_methods()
{
const string Source = @"
using Spectre.Console;
internal sealed class Foo
{
private readonly IAnsiConsole _console;
public Foo(IAnsiConsole console = null)
{
_console = console ?? AnsiConsole.Create(new AnsiConsoleSettings());
}
}
";
await SpectreAnalyzerVerifier<FavorInstanceAnsiConsoleOverStaticAnalyzer>
.VerifyAnalyzerAsync(Source)
.ConfigureAwait(false);
}
[Fact] [Fact]
public async void Instance_console_has_no_warnings() public async void Instance_console_has_no_warnings()
{ {