mirror of
https://github.com/nsnail/Ocelot.git
synced 2025-05-04 10:02:49 +08:00

* started messing around with this on the train last night * mega hacking away to change middleware into Ocelot iddleware * scoped data repo back in * broken commit getting tests working * another broken commit farting around with tests * all unit tests passing again * mw pipeline for ocelot...still loads of hacks but getting there now to get acceptance tests working, then fix config so you can have aggregate and then imlement multiplexer, then mapping to response...loads to do * all tests passing before aggregation feature implemented * removed all the request middleware stuff we dont need it * updated how errors work...tho i think there could be edge case here when aggregating because one downstream could error and this would effect another * removed multiplexer so you dont have to send route down, this isnt very thread safe...sigh * hacking around getting the config for aggregates in, this might change * refactored builder and unit tests passing now * Updated a bunch of ports for tests * plugged in code to create reroutes that are aggregates * made multiplexer a class * hacked test to death * simple aggregator done, initial validation done * removed request id from context, it is still specific for http request * now aggregates to json always * docs for aggregate reroutes * Updated docs
1067 lines
44 KiB
C#
1067 lines
44 KiB
C#
using System.Collections.Generic;
|
|
using System.Security.Claims;
|
|
using System.Text.Encodings.Web;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.AspNetCore.Authentication;
|
|
using Microsoft.Extensions.Logging;
|
|
using Microsoft.Extensions.Options;
|
|
using Moq;
|
|
using Ocelot.Configuration.File;
|
|
using Ocelot.Configuration.Validator;
|
|
using Ocelot.Responses;
|
|
using Shouldly;
|
|
using TestStack.BDDfy;
|
|
using Xunit;
|
|
|
|
namespace Ocelot.UnitTests.Configuration
|
|
{
|
|
public class ConfigurationFluentValidationTests
|
|
{
|
|
private readonly IConfigurationValidator _configurationValidator;
|
|
private FileConfiguration _fileConfiguration;
|
|
private Response<ConfigurationValidationResult> _result;
|
|
private readonly Mock<IAuthenticationSchemeProvider> _provider;
|
|
|
|
public ConfigurationFluentValidationTests()
|
|
{
|
|
_provider = new Mock<IAuthenticationSchemeProvider>();
|
|
_configurationValidator = new FileConfigurationFluentValidator(_provider.Object);
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_if_aggregates_are_valid()
|
|
{
|
|
var configuration = new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51878,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/laura",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
Key = "Laura"
|
|
},
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51880,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/tom",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
Key = "Tom"
|
|
}
|
|
},
|
|
Aggregates = new List<FileAggregateReRoute>
|
|
{
|
|
new FileAggregateReRoute
|
|
{
|
|
UpstreamPathTemplate = "/",
|
|
UpstreamHost = "localhost",
|
|
ReRouteKeys = new List<string>
|
|
{
|
|
"Tom",
|
|
"Laura"
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
this.Given(x => x.GivenAConfiguration(configuration))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_if_aggregates_are_duplicate_of_re_routes()
|
|
{
|
|
var configuration = new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51878,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/laura",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
Key = "Laura"
|
|
},
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51880,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/tom",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
Key = "Tom",
|
|
UpstreamHost = "localhost"
|
|
}
|
|
},
|
|
Aggregates = new List<FileAggregateReRoute>
|
|
{
|
|
new FileAggregateReRoute
|
|
{
|
|
UpstreamPathTemplate = "/tom",
|
|
UpstreamHost = "localhost",
|
|
ReRouteKeys = new List<string>
|
|
{
|
|
"Tom",
|
|
"Laura"
|
|
},
|
|
}
|
|
}
|
|
};
|
|
|
|
this.Given(x => x.GivenAConfiguration(configuration))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "reRoute /tom has duplicate aggregate"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_if_aggregates_are_not_duplicate_of_re_routes()
|
|
{
|
|
var configuration = new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51878,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/laura",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
Key = "Laura"
|
|
},
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51880,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/tom",
|
|
UpstreamHttpMethod = new List<string> { "Post" },
|
|
Key = "Tom",
|
|
UpstreamHost = "localhost"
|
|
}
|
|
},
|
|
Aggregates = new List<FileAggregateReRoute>
|
|
{
|
|
new FileAggregateReRoute
|
|
{
|
|
UpstreamPathTemplate = "/tom",
|
|
UpstreamHost = "localhost",
|
|
ReRouteKeys = new List<string>
|
|
{
|
|
"Tom",
|
|
"Laura"
|
|
},
|
|
}
|
|
}
|
|
};
|
|
|
|
this.Given(x => x.GivenAConfiguration(configuration))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_if_aggregates_are_duplicate_of_aggregates()
|
|
{
|
|
var configuration = new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51878,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/laura",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
Key = "Laura"
|
|
},
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51880,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/lol",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
Key = "Tom"
|
|
}
|
|
},
|
|
Aggregates = new List<FileAggregateReRoute>
|
|
{
|
|
new FileAggregateReRoute
|
|
{
|
|
UpstreamPathTemplate = "/tom",
|
|
UpstreamHost = "localhost",
|
|
ReRouteKeys = new List<string>
|
|
{
|
|
"Tom",
|
|
"Laura"
|
|
}
|
|
},
|
|
new FileAggregateReRoute
|
|
{
|
|
UpstreamPathTemplate = "/tom",
|
|
UpstreamHost = "localhost",
|
|
ReRouteKeys = new List<string>
|
|
{
|
|
"Tom",
|
|
"Laura"
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
this.Given(x => x.GivenAConfiguration(configuration))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "aggregate /tom has duplicate aggregate"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_if_re_routes_dont_exist_for_aggregate()
|
|
{
|
|
var configuration = new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51878,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/laura",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
Key = "Laura"
|
|
}
|
|
},
|
|
Aggregates = new List<FileAggregateReRoute>
|
|
{
|
|
new FileAggregateReRoute
|
|
{
|
|
UpstreamPathTemplate = "/",
|
|
UpstreamHost = "localhost",
|
|
ReRouteKeys = new List<string>
|
|
{
|
|
"Tom",
|
|
"Laura"
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
this.Given(x => x.GivenAConfiguration(configuration))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "ReRoutes for aggregateReRoute / either do not exist or do not have correct Key property"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_if_aggregate_has_re_routes_with_specific_request_id_keys()
|
|
{
|
|
var configuration = new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51878,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/laura",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
Key = "Laura"
|
|
},
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/",
|
|
DownstreamScheme = "http",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "localhost",
|
|
Port = 51880,
|
|
}
|
|
},
|
|
UpstreamPathTemplate = "/tom",
|
|
UpstreamHttpMethod = new List<string> { "Get" },
|
|
RequestIdKey = "should_fail",
|
|
Key = "Tom"
|
|
}
|
|
},
|
|
Aggregates = new List<FileAggregateReRoute>
|
|
{
|
|
new FileAggregateReRoute
|
|
{
|
|
UpstreamPathTemplate = "/",
|
|
UpstreamHost = "localhost",
|
|
ReRouteKeys = new List<string>
|
|
{
|
|
"Tom",
|
|
"Laura"
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
this.Given(x => x.GivenAConfiguration(configuration))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "aggregateReRoute / contains ReRoute with specific RequestIdKey, this is not possible with Aggregates"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_if_scheme_in_downstream_or_upstream_template()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "http://www.bbc.co.uk/api/products/{productId}",
|
|
UpstreamPathTemplate = "http://asdf.com"
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.Then(x => x.ThenTheErrorIs<FileValidationFailedError>())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "Downstream Path Template http://www.bbc.co.uk/api/products/{productId} doesnt start with forward slash"))
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(1, "Upstream Path Template http://asdf.com contains double forward slash, Ocelot does not support this at the moment. Please raise an issue in GitHib if you need this feature."))
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(2, "Downstream Path Template http://www.bbc.co.uk/api/products/{productId} contains double forward slash, Ocelot does not support this at the moment. Please raise an issue in GitHib if you need this feature."))
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(3, "Upstream Path Template http://asdf.com doesnt start with forward slash"))
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(4, "Downstream Path Template http://www.bbc.co.uk/api/products/{productId} contains scheme"))
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(5, "Upstream Path Template http://asdf.com contains scheme"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_with_one_reroute()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk"
|
|
}
|
|
},
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_without_slash_prefix_downstream_path_template()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "api/products/",
|
|
UpstreamPathTemplate = "/asdf/"
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "Downstream Path Template api/products/ doesnt start with forward slash"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_without_slash_prefix_upstream_path_template()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "api/prod/",
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "Upstream Path Template api/prod/ doesnt start with forward slash"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_if_upstream_url_contains_forward_slash_then_another_forward_slash()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "//api/prod/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk",
|
|
Port = 80
|
|
}
|
|
},
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "Upstream Path Template //api/prod/ contains double forward slash, Ocelot does not support this at the moment. Please raise an issue in GitHib if you need this feature."))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_if_downstream_url_contains_forward_slash_then_another_forward_slash()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "//api/products/",
|
|
UpstreamPathTemplate = "/api/prod/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk",
|
|
Port = 80
|
|
}
|
|
},
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "Downstream Path Template //api/products/ contains double forward slash, Ocelot does not support this at the moment. Please raise an issue in GitHib if you need this feature."))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_with_valid_authentication_provider()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk",
|
|
}
|
|
},
|
|
AuthenticationOptions = new FileAuthenticationOptions()
|
|
{
|
|
AuthenticationProviderKey = "Test"
|
|
}
|
|
}
|
|
}
|
|
}))
|
|
.And(x => x.GivenTheAuthSchemeExists("Test"))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_with_invalid_authentication_provider()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
AuthenticationOptions = new FileAuthenticationOptions()
|
|
{
|
|
AuthenticationProviderKey = "Test"
|
|
} }
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "AuthenticationProviderKey:Test,AllowedScopes:[] is unsupported authentication provider"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_not_valid_with_duplicate_reroutes_all_verbs()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bb.co.uk"
|
|
}
|
|
},
|
|
},
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/www/test/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bb.co.uk"
|
|
}
|
|
},
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "reRoute /asdf/ has duplicate"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_with_duplicate_reroutes_all_verbs_but_different_hosts()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bb.co.uk"
|
|
}
|
|
},
|
|
UpstreamHost = "host1"
|
|
},
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/www/test/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bb.co.uk"
|
|
}
|
|
},
|
|
UpstreamHost = "host1"
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_not_valid_with_duplicate_reroutes_specific_verbs()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk",
|
|
}
|
|
},
|
|
UpstreamHttpMethod = new List<string> {"Get"}
|
|
},
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/www/test/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk",
|
|
}
|
|
},
|
|
UpstreamHttpMethod = new List<string> {"Get"}
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "reRoute /asdf/ has duplicate"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_with_duplicate_reroutes_different_verbs()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk",
|
|
}
|
|
},
|
|
},
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/www/test/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Post"},
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk",
|
|
}
|
|
},
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_invalid_with_invalid_rate_limit_configuration()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk",
|
|
}
|
|
},
|
|
RateLimitOptions = new FileRateLimitRule
|
|
{
|
|
Period = "1x",
|
|
EnableRateLimiting = true
|
|
}
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "RateLimitOptions.Period does not contains (s,m,h,d)"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_with_valid_rate_limit_configuration()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk",
|
|
}
|
|
},
|
|
RateLimitOptions = new FileRateLimitRule
|
|
{
|
|
Period = "1d",
|
|
EnableRateLimiting = true
|
|
}
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(null)]
|
|
[InlineData("")]
|
|
public void configuration_is_invalid_with_using_service_discovery_and_no_service_name(string serviceName)
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
UseServiceDiscovery = true,
|
|
ServiceName = serviceName
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "ServiceName cannot be empty or null when using service discovery or Ocelot cannot look up your service!"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_with_using_service_discovery_and_service_name()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
UseServiceDiscovery = true,
|
|
ServiceName = "Test"
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
|
|
[Theory]
|
|
[InlineData(null)]
|
|
[InlineData("")]
|
|
public void configuration_is_invalid_when_not_using_service_discovery_and_host(string downstreamHost)
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
UseServiceDiscovery = false,
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = downstreamHost,
|
|
}
|
|
},
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "When not using service discovery Host must be set on DownstreamHostAndPorts if you are not using ReRoute.Host or Ocelot cannot find your service!"))
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_when_not_using_service_discovery_and_host_is_set()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
UseServiceDiscovery = false,
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "bbc.co.uk"
|
|
}
|
|
},
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_valid_when_no_downstream_but_has_host_and_port()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
UseServiceDiscovery = false,
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort
|
|
{
|
|
Host = "test"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsValid())
|
|
.BDDfy();
|
|
}
|
|
|
|
[Fact]
|
|
public void configuration_is_not_valid_when_no_host_and_port()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
UseServiceDiscovery = false,
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
}
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "When not using service discovery DownstreamHostAndPorts must be set and not empty or Ocelot cannot find your service!"))
|
|
.BDDfy();
|
|
}
|
|
[Fact]
|
|
public void configuration_is_not_valid_when_host_and_port_is_empty()
|
|
{
|
|
this.Given(x => x.GivenAConfiguration(new FileConfiguration
|
|
{
|
|
ReRoutes = new List<FileReRoute>
|
|
{
|
|
new FileReRoute
|
|
{
|
|
DownstreamPathTemplate = "/api/products/",
|
|
UpstreamPathTemplate = "/asdf/",
|
|
UpstreamHttpMethod = new List<string> {"Get"},
|
|
UseServiceDiscovery = false,
|
|
DownstreamHostAndPorts = new List<FileHostAndPort>
|
|
{
|
|
new FileHostAndPort()
|
|
}
|
|
}
|
|
}
|
|
}))
|
|
.When(x => x.WhenIValidateTheConfiguration())
|
|
.Then(x => x.ThenTheResultIsNotValid())
|
|
.And(x => x.ThenTheErrorMessageAtPositionIs(0, "When not using service discovery Host must be set on DownstreamHostAndPorts if you are not using ReRoute.Host or Ocelot cannot find your service!"))
|
|
.BDDfy();
|
|
}
|
|
|
|
|
|
private void GivenAConfiguration(FileConfiguration fileConfiguration)
|
|
{
|
|
_fileConfiguration = fileConfiguration;
|
|
}
|
|
|
|
private void WhenIValidateTheConfiguration()
|
|
{
|
|
_result = _configurationValidator.IsValid(_fileConfiguration).Result;
|
|
}
|
|
|
|
private void ThenTheResultIsValid()
|
|
{
|
|
_result.Data.IsError.ShouldBeFalse();
|
|
}
|
|
|
|
private void ThenTheResultIsNotValid()
|
|
{
|
|
_result.Data.IsError.ShouldBeTrue();
|
|
}
|
|
|
|
private void ThenTheErrorIs<T>()
|
|
{
|
|
_result.Data.Errors[0].ShouldBeOfType<T>();
|
|
}
|
|
|
|
private void ThenTheErrorMessageAtPositionIs(int index, string expected)
|
|
{
|
|
_result.Data.Errors[index].Message.ShouldBe(expected);
|
|
}
|
|
|
|
private void GivenTheAuthSchemeExists(string name)
|
|
{
|
|
_provider.Setup(x => x.GetAllSchemesAsync()).ReturnsAsync(new List<AuthenticationScheme>
|
|
{
|
|
new AuthenticationScheme(name, name, typeof(TestHandler))
|
|
});
|
|
}
|
|
|
|
private class TestOptions : AuthenticationSchemeOptions
|
|
{
|
|
}
|
|
|
|
private class TestHandler : AuthenticationHandler<TestOptions>
|
|
{
|
|
public TestHandler(IOptionsMonitor<TestOptions> options, ILoggerFactory logger, UrlEncoder encoder, ISystemClock clock) : base(options, logger, encoder, clock)
|
|
{
|
|
}
|
|
|
|
protected override Task<AuthenticateResult> HandleAuthenticateAsync()
|
|
{
|
|
var principal = new ClaimsPrincipal();
|
|
return Task.FromResult(AuthenticateResult.Success(new AuthenticationTicket(principal, new AuthenticationProperties(), Scheme.Name)));
|
|
}
|
|
}
|
|
}
|
|
}
|