mirror of
				https://github.com/nsnail/Ocelot.git
				synced 2025-11-04 10:15:27 +08:00 
			
		
		
		
	Refactor qos as options
This commit is contained in:
		@@ -10,6 +10,7 @@ using Ocelot.Responses;
 | 
			
		||||
using Shouldly;
 | 
			
		||||
using TestStack.BDDfy;
 | 
			
		||||
using Xunit;
 | 
			
		||||
using Ocelot.Configuration;
 | 
			
		||||
 | 
			
		||||
namespace Ocelot.UnitTests.Request
 | 
			
		||||
{
 | 
			
		||||
@@ -25,7 +26,8 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
        private readonly IRequestCreator _requestCreator;
 | 
			
		||||
        private Response<Ocelot.Request.Request> _result;
 | 
			
		||||
        private Ocelot.RequestId.RequestId _requestId;
 | 
			
		||||
        private Ocelot.Values.QoS _qos;
 | 
			
		||||
        private bool _isQos;
 | 
			
		||||
        private QoSOptions _qos;
 | 
			
		||||
 | 
			
		||||
        public RequestBuilderTests()
 | 
			
		||||
        {
 | 
			
		||||
@@ -38,7 +40,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
        {
 | 
			
		||||
            this.Given(x => x.GivenIHaveHttpMethod("GET"))
 | 
			
		||||
                .And(x => x.GivenIHaveDownstreamUrl("http://www.bbc.co.uk"))
 | 
			
		||||
                .And(x=> x.GivenTheQos(new Values.QoS(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                .And(x=> x.GivenTheQos(true,new QoSOptions(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                .When(x => x.WhenICreateARequest())
 | 
			
		||||
                .And(x => x.ThenTheCorrectDownstreamUrlIsUsed("http://www.bbc.co.uk/"))
 | 
			
		||||
                .BDDfy();
 | 
			
		||||
@@ -49,7 +51,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
        {
 | 
			
		||||
            this.Given(x => x.GivenIHaveHttpMethod("POST"))
 | 
			
		||||
                .And(x => x.GivenIHaveDownstreamUrl("http://www.bbc.co.uk"))
 | 
			
		||||
                .And(x => x.GivenTheQos(new Values.QoS(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                .And(x => x.GivenTheQos(true,new QoSOptions(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
 | 
			
		||||
                .When(x => x.WhenICreateARequest())
 | 
			
		||||
                .And(x => x.ThenTheCorrectHttpMethodIsUsed(HttpMethod.Post))
 | 
			
		||||
@@ -63,7 +65,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
                .And(x => x.GivenIHaveDownstreamUrl("http://www.bbc.co.uk"))
 | 
			
		||||
                .And(x => x.GivenIHaveTheHttpContent(new StringContent("Hi from Tom")))
 | 
			
		||||
                .And(x => x.GivenTheContentTypeIs("application/json"))
 | 
			
		||||
                              .And(x => x.GivenTheQos(new Values.QoS(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                              .And(x => x.GivenTheQos(true, new QoSOptions(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
 | 
			
		||||
                              .When(x => x.WhenICreateARequest())
 | 
			
		||||
               .And(x => x.ThenTheCorrectContentIsUsed(new StringContent("Hi from Tom")))
 | 
			
		||||
@@ -77,7 +79,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
                .And(x => x.GivenIHaveDownstreamUrl("http://www.bbc.co.uk"))
 | 
			
		||||
                .And(x => x.GivenIHaveTheHttpContent(new StringContent("Hi from Tom")))
 | 
			
		||||
                .And(x => x.GivenTheContentTypeIs("application/json"))
 | 
			
		||||
                .And(x => x.GivenTheQos(new Values.QoS(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                .And(x => x.GivenTheQos(true, new QoSOptions(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
 | 
			
		||||
               .When(x => x.WhenICreateARequest())
 | 
			
		||||
               .And(x => x.ThenTheCorrectContentHeadersAreUsed(new HeaderDictionary
 | 
			
		||||
@@ -96,7 +98,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
                .And(x => x.GivenIHaveDownstreamUrl("http://www.bbc.co.uk"))
 | 
			
		||||
                .And(x => x.GivenIHaveTheHttpContent(new StringContent("Hi from Tom")))
 | 
			
		||||
                .And(x => x.GivenTheContentTypeIs("application/json; charset=utf-8"))
 | 
			
		||||
                                .And(x => x.GivenTheQos(new Values.QoS(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                                .And(x => x.GivenTheQos(true, new QoSOptions(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
 | 
			
		||||
               .When(x => x.WhenICreateARequest())
 | 
			
		||||
               .And(x => x.ThenTheCorrectContentHeadersAreUsed(new HeaderDictionary
 | 
			
		||||
@@ -117,7 +119,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
                {
 | 
			
		||||
                    {"ChopSticks", "Bubbles" }
 | 
			
		||||
                }))
 | 
			
		||||
                                .And(x => x.GivenTheQos(new Values.QoS(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                                .And(x => x.GivenTheQos(true, new QoSOptions(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
 | 
			
		||||
                .When(x => x.WhenICreateARequest())
 | 
			
		||||
                .And(x => x.ThenTheCorrectHeadersAreUsed(new HeaderDictionary
 | 
			
		||||
@@ -136,7 +138,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
                .And(x => x.GivenIHaveDownstreamUrl("http://www.bbc.co.uk"))
 | 
			
		||||
                .And(x => x.GivenTheHttpHeadersAre(new HeaderDictionary()))
 | 
			
		||||
                .And(x => x.GivenTheRequestIdIs(new Ocelot.RequestId.RequestId("RequestId", requestId)))
 | 
			
		||||
                              .And(x => x.GivenTheQos(new Values.QoS(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                              .And(x => x.GivenTheQos(true, new QoSOptions(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
  .When(x => x.WhenICreateARequest())
 | 
			
		||||
                .And(x => x.ThenTheCorrectHeadersAreUsed(new HeaderDictionary
 | 
			
		||||
                {
 | 
			
		||||
@@ -155,7 +157,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
                    {"RequestId", "534534gv54gv45g" }
 | 
			
		||||
                }))
 | 
			
		||||
                .And(x => x.GivenTheRequestIdIs(new Ocelot.RequestId.RequestId("RequestId", Guid.NewGuid().ToString())))
 | 
			
		||||
                               .And(x => x.GivenTheQos(new Values.QoS(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                               .And(x => x.GivenTheQos(true, new QoSOptions(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
 .When(x => x.WhenICreateARequest())
 | 
			
		||||
                .And(x => x.ThenTheCorrectHeadersAreUsed(new HeaderDictionary
 | 
			
		||||
                {
 | 
			
		||||
@@ -175,7 +177,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
                .And(x => x.GivenIHaveDownstreamUrl("http://www.bbc.co.uk"))
 | 
			
		||||
                .And(x => x.GivenTheHttpHeadersAre(new HeaderDictionary()))
 | 
			
		||||
                .And(x => x.GivenTheRequestIdIs(new Ocelot.RequestId.RequestId(requestIdKey, requestIdValue)))
 | 
			
		||||
                              .And(x => x.GivenTheQos(new Values.QoS(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
                              .And(x => x.GivenTheQos(true, new QoSOptions(3, 8, 5000, Polly.Timeout.TimeoutStrategy.Pessimistic)))
 | 
			
		||||
  .When(x => x.WhenICreateARequest())
 | 
			
		||||
                .And(x => x.ThenTheRequestIdIsNotInTheHeaders())
 | 
			
		||||
                .BDDfy();
 | 
			
		||||
@@ -186,8 +188,9 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
            _requestId = requestId;
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        private void GivenTheQos(Ocelot.Values.QoS qos)
 | 
			
		||||
        private void GivenTheQos(bool isQos, QoSOptions qos)
 | 
			
		||||
        {
 | 
			
		||||
            _isQos = isQos;
 | 
			
		||||
            _qos = qos;
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
@@ -301,7 +304,7 @@ namespace Ocelot.UnitTests.Request
 | 
			
		||||
        private void WhenICreateARequest()
 | 
			
		||||
        {
 | 
			
		||||
            _result = _requestCreator.Build(_httpMethod, _downstreamUrl, _content?.ReadAsStreamAsync().Result, _headers,
 | 
			
		||||
                _cookies, _query, _contentType, _requestId, _qos).Result;
 | 
			
		||||
                _cookies, _query, _contentType, _requestId,_isQos,_qos).Result;
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user