refactoring ocelot config creation process

2025-11-04 20:30:50 +08:00 · 2017-03-01 07:54:07 +00:00
parent 1d216f6863
commit c85ea41951
12 changed files with 517 additions and 280 deletions
--- a/test/Ocelot.UnitTests/Configuration/ClaimsToThingCreatorTests.cs
+++ b/test/Ocelot.UnitTests/Configuration/ClaimsToThingCreatorTests.cs
@@ -0,0 +1,110 @@
+using System.Collections.Generic;
+using System.Linq;
+using Moq;
+using Ocelot.Configuration;
+using Ocelot.Configuration.Creator;
+using Ocelot.Configuration.Parser;
+using Ocelot.Errors;
+using Ocelot.Logging;
+using Ocelot.Responses;
+using Shouldly;
+using TestStack.BDDfy;
+using Xunit;
+
+namespace Ocelot.UnitTests.Configuration
+{
+    public class ClaimsToThingCreatorTests
+    {
+        private readonly Mock<IClaimToThingConfigurationParser> _configParser;
+        private Dictionary<string,string> _claimsToThings;
+        private ClaimsToThingCreator _claimsToThingsCreator;
+        private Mock<IOcelotLoggerFactory> _loggerFactory;
+        private List<ClaimToThing> _result;
+        private Mock<IOcelotLogger> _logger;
+
+        public ClaimsToThingCreatorTests()
+        {
+            _loggerFactory = new Mock<IOcelotLoggerFactory>();
+            _logger = new Mock<IOcelotLogger>();
+            _loggerFactory
+                .Setup(x => x.CreateLogger<ClaimsToThingCreator>())
+                .Returns(_logger.Object);
+            _configParser = new Mock<IClaimToThingConfigurationParser>();
+            _claimsToThingsCreator = new ClaimsToThingCreator(_configParser.Object, _loggerFactory.Object);
+        }
+
+        [Fact]
+        public void should_return_claims_to_things()
+        {
+            var userInput = new Dictionary<string,string>()
+            {
+                {"CustomerId", "Claims[CustomerId] > value"}
+            };
+
+            var claimsToThing = new OkResponse<ClaimToThing>(new ClaimToThing("CustomerId", "CustomerId", "", 0));
+                    
+            this.Given(x => x.GivenTheFollowingDictionary(userInput))
+                .And(x => x.GivenTheConfigHeaderExtractorReturns(claimsToThing))
+                .When(x => x.WhenIGetTheThings())
+                .Then(x => x.ThenTheConfigParserIsCalledCorrectly())
+                .And(x => x.ThenClaimsToThingsAreReturned())
+                .BDDfy();
+        }
+
+        [Fact]
+        public void should_log_error_if_cannot_parse_claim_to_thing()
+        {
+             var userInput = new Dictionary<string,string>()
+            {
+                {"CustomerId", "Claims[CustomerId] > value"}
+            };
+
+            var claimsToThing = new ErrorResponse<ClaimToThing>(It.IsAny<Error>());
+                    
+            this.Given(x => x.GivenTheFollowingDictionary(userInput))
+                .And(x => x.GivenTheConfigHeaderExtractorReturns(claimsToThing))
+                .When(x => x.WhenIGetTheThings())
+                .Then(x => x.ThenTheConfigParserIsCalledCorrectly())
+                .And(x => x.ThenNoClaimsToThingsAreReturned())
+                .BDDfy();
+        }
+
+        private void ThenTheLoggerIsCalledCorrectly()
+        {
+            _logger
+                .Verify(x => x.LogDebug(It.IsAny<string>(), It.IsAny<string>()), Times.Once);
+        }
+
+        private void ThenClaimsToThingsAreReturned()
+        {
+            _result.Count.ShouldBeGreaterThan(0);
+        }
+        private void GivenTheFollowingDictionary(Dictionary<string,string> claimsToThings)
+        {
+            _claimsToThings = claimsToThings;
+        }
+
+        private void GivenTheConfigHeaderExtractorReturns(Response<ClaimToThing> expected)
+        {
+            _configParser
+                .Setup(x => x.Extract(It.IsAny<string>(), It.IsAny<string>()))
+                .Returns(expected);
+        }
+
+        private void ThenNoClaimsToThingsAreReturned()
+        {
+            _result.Count.ShouldBe(0);
+        }
+
+        private void WhenIGetTheThings()
+        {
+            _result = _claimsToThingsCreator.Create(_claimsToThings);
+        }
+
+        private void ThenTheConfigParserIsCalledCorrectly()
+        {
+            _configParser
+                .Verify(x => x.Extract(_claimsToThings.First().Key, _claimsToThings.First().Value), Times.Once);
+        }
+    }
+}