From c01f778bf9ad715e29a407c40f37ffa67b73f367 Mon Sep 17 00:00:00 2001 From: Marc Denman Date: Tue, 14 Mar 2017 10:06:53 +0000 Subject: [PATCH] Add LogTrace to IOcelotLogger Previously only LogDebug and LogError were implemented, however this could/will lead to very noisy logging. Implementing trace should allow a better seperation when debugging. --- src/Ocelot/Logging/IOcelotLoggerFactory.cs | 6 ++++++ src/Ocelot/Responder/Middleware/ResponderMiddleware.cs | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/Ocelot/Logging/IOcelotLoggerFactory.cs b/src/Ocelot/Logging/IOcelotLoggerFactory.cs index 5305088f..50e5b25e 100644 --- a/src/Ocelot/Logging/IOcelotLoggerFactory.cs +++ b/src/Ocelot/Logging/IOcelotLoggerFactory.cs @@ -29,6 +29,7 @@ namespace Ocelot.Logging public interface IOcelotLogger { + void LogTrace(string message, params object[] args); void LogDebug(string message, params object[] args); void LogError(string message, Exception exception); } @@ -44,6 +45,11 @@ namespace Ocelot.Logging _scopedDataRepository = scopedDataRepository; } + public void LogTrace(string message, params object[] args) + { + _logger.LogTrace(GetMessageWithOcelotRequestId(message), args); + } + public void LogDebug(string message, params object[] args) { _logger.LogDebug(GetMessageWithOcelotRequestId(message), args); diff --git a/src/Ocelot/Responder/Middleware/ResponderMiddleware.cs b/src/Ocelot/Responder/Middleware/ResponderMiddleware.cs index 1605fb06..2e6585d6 100644 --- a/src/Ocelot/Responder/Middleware/ResponderMiddleware.cs +++ b/src/Ocelot/Responder/Middleware/ResponderMiddleware.cs @@ -34,11 +34,11 @@ namespace Ocelot.Responder.Middleware public async Task Invoke(HttpContext context) { - _logger.LogDebug($"entered {MiddlwareName}"); + _logger.LogTrace($"entered {MiddlwareName}"); _logger.LogDebug($"invoking next middleware from {MiddlwareName}"); await _next.Invoke(context); - + _logger.LogDebug($"returned to {MiddlwareName} after next middleware completed"); if (PipelineError) @@ -53,7 +53,7 @@ namespace Ocelot.Responder.Middleware _logger.LogDebug("no pipeline errors, setting and returning completed response"); await _responder.SetResponseOnHttpContext(context, HttpResponseMessage); } - _logger.LogDebug($"completed {MiddlwareName}"); + _logger.LogTrace($"completed {MiddlwareName}"); } private void SetErrorResponse(HttpContext context, List errors)