diff --git a/src/Ocelot/DownstreamRouteFinder/UrlMatcher/UrlPathPlaceholderNameAndValueFinder.cs b/src/Ocelot/DownstreamRouteFinder/UrlMatcher/UrlPathPlaceholderNameAndValueFinder.cs index 249b153e..0859f4c0 100644 --- a/src/Ocelot/DownstreamRouteFinder/UrlMatcher/UrlPathPlaceholderNameAndValueFinder.cs +++ b/src/Ocelot/DownstreamRouteFinder/UrlMatcher/UrlPathPlaceholderNameAndValueFinder.cs @@ -18,8 +18,8 @@ namespace Ocelot.DownstreamRouteFinder.UrlMatcher if (IsPlaceholder(upstreamUrlPathTemplate[counterForTemplate])) { var variableName = GetPlaceholderVariableName(upstreamUrlPathTemplate, counterForTemplate); - - var variableValue = GetPlaceholderVariableValue(upstreamUrlPath, counterForUrl); + + var variableValue = GetPlaceholderVariableValue(upstreamUrlPathTemplate, variableName, upstreamUrlPath, counterForUrl); var templateVariableNameAndValue = new UrlPathPlaceholderNameAndValue(variableName, variableValue); @@ -40,15 +40,15 @@ namespace Ocelot.DownstreamRouteFinder.UrlMatcher return new OkResponse>(templateKeysAndValues); } - private string GetPlaceholderVariableValue(string urlPath, int counterForUrl) + private string GetPlaceholderVariableValue(string urlPathTemplate, string variableName, string urlPath, int counterForUrl) { var positionOfNextSlash = urlPath.IndexOf('/', counterForUrl); - if(positionOfNextSlash == -1) + if (positionOfNextSlash == -1 || urlPathTemplate.Trim('/').EndsWith(variableName)) { positionOfNextSlash = urlPath.Length; } - + var variableValue = urlPath.Substring(counterForUrl, positionOfNextSlash - counterForUrl); return variableValue; diff --git a/test/Ocelot.UnitTests/DownstreamRouteFinder/UrlMatcher/TemplateVariableNameAndValueFinderTests.cs b/test/Ocelot.UnitTests/DownstreamRouteFinder/UrlMatcher/TemplateVariableNameAndValueFinderTests.cs index cf71c809..7c73483a 100644 --- a/test/Ocelot.UnitTests/DownstreamRouteFinder/UrlMatcher/TemplateVariableNameAndValueFinderTests.cs +++ b/test/Ocelot.UnitTests/DownstreamRouteFinder/UrlMatcher/TemplateVariableNameAndValueFinderTests.cs @@ -140,6 +140,21 @@ namespace Ocelot.UnitTests.DownstreamRouteFinder.UrlMatcher .BDDfy(); } + [Fact] + public void can_match_down_stream_url_with_downstream_template_with_place_holder_to_final_url_path() + { + var expectedTemplates = new List + { + new UrlPathPlaceholderNameAndValue("{finalUrlPath}", "product/products/categories/"), + }; + + this.Given(x => x.GivenIHaveAUpstreamPath("api/product/products/categories/")) + .And(x => x.GivenIHaveAnUpstreamUrlTemplate("api/{finalUrlPath}/")) + .When(x => x.WhenIFindTheUrlVariableNamesAndValues()) + .And(x => x.ThenTheTemplatesVariablesAre(expectedTemplates)) + .BDDfy(); + } + private void ThenTheTemplatesVariablesAre(List expectedResults) { foreach (var expectedResult in expectedResults)