From b300ed9aec7b1866d14d437cd67f2923425b809e Mon Sep 17 00:00:00 2001 From: TomPallister Date: Mon, 13 Apr 2020 11:14:28 +0100 Subject: [PATCH] small refactor --- .../LoadBalancers/LoadBalancerFactory.cs | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/Ocelot/LoadBalancer/LoadBalancers/LoadBalancerFactory.cs b/src/Ocelot/LoadBalancer/LoadBalancers/LoadBalancerFactory.cs index 6f0fd5e9..f005bb2f 100644 --- a/src/Ocelot/LoadBalancer/LoadBalancers/LoadBalancerFactory.cs +++ b/src/Ocelot/LoadBalancer/LoadBalancers/LoadBalancerFactory.cs @@ -4,7 +4,6 @@ using System.Linq; using Ocelot.Configuration; using Ocelot.Responses; - using System.Threading.Tasks; using Ocelot.ServiceDiscovery; public class LoadBalancerFactory : ILoadBalancerFactory @@ -22,21 +21,16 @@ { var serviceProviderFactoryResponse = _serviceProviderFactory.Get(config, reRoute); - Response response; if (serviceProviderFactoryResponse.IsError) { - response = new ErrorResponse(serviceProviderFactoryResponse.Errors); - } - else - { - var serviceProvider = serviceProviderFactoryResponse.Data; - var requestedType = reRoute.LoadBalancerOptions?.Type ?? nameof(NoLoadBalancer); - var applicableCreator = _loadBalancerCreators.Single(c => c.Type == requestedType); - var createdLoadBalancer = applicableCreator.Create(reRoute, serviceProvider); - response = new OkResponse(createdLoadBalancer); + return new ErrorResponse(serviceProviderFactoryResponse.Errors); } - return response; + var serviceProvider = serviceProviderFactoryResponse.Data; + var requestedType = reRoute.LoadBalancerOptions?.Type ?? nameof(NoLoadBalancer); + var applicableCreator = _loadBalancerCreators.Single(c => c.Type == requestedType); + var createdLoadBalancer = applicableCreator.Create(reRoute, serviceProvider); + return new OkResponse(createdLoadBalancer); } } }