tidy up and no longer hard code admin area...still one int test failing before we start looking at rebuilding auth stuff

This commit is contained in:
Tom Gardham-Pallister
2017-10-29 16:35:12 +00:00
parent 24c018721f
commit b28fc6694e
6 changed files with 13 additions and 20 deletions

View File

@ -147,13 +147,13 @@ namespace Ocelot.DependencyInjection
if (identityServerConfiguration != null)
{
services.AddIdentityServer(identityServerConfiguration);
services.AddIdentityServer(identityServerConfiguration, configurationRoot);
}
return services;
}
private static void AddIdentityServer(this IServiceCollection services, IIdentityServerConfiguration identityServerConfiguration)
private static void AddIdentityServer(this IServiceCollection services, IIdentityServerConfiguration identityServerConfiguration, IConfigurationRoot configurationRoot)
{
services.TryAddSingleton<IIdentityServerConfiguration>(identityServerConfiguration);
services.TryAddSingleton<IHashMatcher, HashMatcher>();
@ -172,8 +172,8 @@ namespace Ocelot.DependencyInjection
services.AddAuthentication(IdentityServerAuthenticationDefaults.AuthenticationScheme)
.AddIdentityServerAuthentication(o =>
{
//todo - this needs to come from the config so have to get it in here...
o.Authority = baseSchemeUrlAndPort + "/administration";
var adminPath = configurationRoot.GetValue("GlobalConfiguration:AdministrationPath", string.Empty);
o.Authority = baseSchemeUrlAndPort + adminPath;
o.ApiName = identityServerConfiguration.ApiName;
o.RequireHttpsMetadata = identityServerConfiguration.RequireHttps;
o.SupportedTokens = SupportedTokens.Both;

View File

@ -41,9 +41,9 @@ namespace Ocelot.Middleware
/// </summary>
/// <param name="builder"></param>
/// <returns></returns>
public static async Task<IApplicationBuilder> UseOcelot(this IApplicationBuilder builder, IServiceCollection services)
public static async Task<IApplicationBuilder> UseOcelot(this IApplicationBuilder builder)
{
await builder.UseOcelot(new OcelotMiddlewareConfiguration(), services);
await builder.UseOcelot(new OcelotMiddlewareConfiguration());
return builder;
}
@ -54,9 +54,9 @@ namespace Ocelot.Middleware
/// <param name="builder"></param>
/// <param name="middlewareConfiguration"></param>
/// <returns></returns>
public static async Task<IApplicationBuilder> UseOcelot(this IApplicationBuilder builder, OcelotMiddlewareConfiguration middlewareConfiguration, IServiceCollection services)
public static async Task<IApplicationBuilder> UseOcelot(this IApplicationBuilder builder, OcelotMiddlewareConfiguration middlewareConfiguration)
{
await CreateAdministrationArea(builder, services);
await CreateAdministrationArea(builder);
ConfigureDiagnosticListener(builder);
@ -173,7 +173,7 @@ namespace Ocelot.Middleware
return ocelotConfiguration.Data;
}
private static async Task CreateAdministrationArea(IApplicationBuilder builder, IServiceCollection services)
private static async Task CreateAdministrationArea(IApplicationBuilder builder)
{
var configuration = await CreateConfiguration(builder);
@ -183,7 +183,6 @@ namespace Ocelot.Middleware
{
builder.Map(configuration.AdministrationPath, app =>
{
Console.WriteLine("SETTING UP ADMIN AREA");
app.UseIdentityServer();
app.UseAuthentication();
app.UseMvc();