mirror of
https://github.com/nsnail/Ocelot.git
synced 2025-06-19 02:18:15 +08:00
Feature/adding some re route specific validation tests (#590)
* started refactoring json config validation stack because ive made it crap * inject validators from DI rather than instanciating, next step mock them * added some unit tests for specific validators on the train yey
This commit is contained in:
Tom Pallister
@ -0,0 +1,368 @@
|
||||
namespace Ocelot.UnitTests.Configuration.Validation
|
||||
{
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Threading.Tasks;
|
||||
using FluentValidation.Results;
|
||||
using Microsoft.AspNetCore.Authentication;
|
||||
using Microsoft.AspNetCore.Http;
|
||||
using Moq;
|
||||
using Ocelot.Configuration.File;
|
||||
using Ocelot.Configuration.Validator;
|
||||
using Ocelot.Requester;
|
||||
using Shouldly;
|
||||
using TestStack.BDDfy;
|
||||
using Xunit;
|
||||
|
||||
public class ReRouteFluentValidatorTests
|
||||
{
|
||||
private readonly ReRouteFluentValidator _validator;
|
||||
private readonly Mock<IAuthenticationSchemeProvider> _authProvider;
|
||||
private QosDelegatingHandlerDelegate _qosDelegatingHandler;
|
||||
private Mock<IServiceProvider> _serviceProvider;
|
||||
private FileReRoute _reRoute;
|
||||
private ValidationResult _result;
|
||||
|
||||
public ReRouteFluentValidatorTests()
|
||||
{
|
||||
_authProvider = new Mock<IAuthenticationSchemeProvider>();
|
||||
_serviceProvider = new Mock<IServiceProvider>();
|
||||
// Todo - replace with mocks
|
||||
_validator = new ReRouteFluentValidator(_authProvider.Object, new HostAndPortValidator(), new FileQoSOptionsFluentValidator(_serviceProvider.Object));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void downstream_path_template_should_not_be_empty()
|
||||
{
|
||||
var fileReRoute = new FileReRoute();
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains("Downstream Path Template cannot be empty"))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void upstream_path_template_should_not_be_empty()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "test"
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains("Upstream Path Template cannot be empty"))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void downstream_path_template_should_start_with_forward_slash()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "test"
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains("Downstream Path Template test doesnt start with forward slash"))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void downstream_path_template_should_not_contain_double_forward_slash()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "//test"
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains("Downstream Path Template //test contains double forward slash, Ocelot does not support this at the moment. Please raise an issue in GitHib if you need this feature."))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("https://test")]
|
||||
[InlineData("http://test")]
|
||||
[InlineData("/test/http://")]
|
||||
[InlineData("/test/https://")]
|
||||
public void downstream_path_template_should_not_contain_scheme(string downstreamPathTemplate)
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = downstreamPathTemplate
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains($"Downstream Path Template {downstreamPathTemplate} contains double forward slash, Ocelot does not support this at the moment. Please raise an issue in GitHib if you need this feature."))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void upstream_path_template_should_start_with_forward_slash()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = "test"
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains("Upstream Path Template test doesnt start with forward slash"))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void upstream_path_template_should_not_contain_double_forward_slash()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = "//test"
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains("Upstream Path Template //test contains double forward slash, Ocelot does not support this at the moment. Please raise an issue in GitHib if you need this feature."))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("https://test")]
|
||||
[InlineData("http://test")]
|
||||
[InlineData("/test/http://")]
|
||||
[InlineData("/test/https://")]
|
||||
public void upstream_path_template_should_not_contain_scheme(string upstreamPathTemplate)
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = upstreamPathTemplate
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains($"Upstream Path Template {upstreamPathTemplate} contains double forward slash, Ocelot does not support this at the moment. Please raise an issue in GitHib if you need this feature."))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void should_not_be_valid_if_enable_rate_limiting_true_and_period_is_empty()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = "/test",
|
||||
RateLimitOptions = new FileRateLimitRule
|
||||
{
|
||||
EnableRateLimiting = true
|
||||
}
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains("RateLimitOptions.Period is empty"))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void should_not_be_valid_if_enable_rate_limiting_true_and_period_has_value()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = "/test",
|
||||
RateLimitOptions = new FileRateLimitRule
|
||||
{
|
||||
EnableRateLimiting = true,
|
||||
Period = "test"
|
||||
}
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains("RateLimitOptions.Period does not contain integer then s (second), m (minute), h (hour), d (day) e.g. 1m for 1 minute period"))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void should_not_be_valid_if_specified_authentication_provider_isnt_registered()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = "/test",
|
||||
AuthenticationOptions = new FileAuthenticationOptions
|
||||
{
|
||||
AuthenticationProviderKey = "JwtLads"
|
||||
}
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains($"Authentication Options AuthenticationProviderKey:JwtLads,AllowedScopes:[] is unsupported authentication provider"))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void should_not_be_valid_if_not_using_service_discovery_and_no_host_and_ports()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = "/test",
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsInvalid())
|
||||
.And(_ => ThenTheErrorsContains("When not using service discovery DownstreamHostAndPorts must be set and not empty or Ocelot cannot find your service!"))
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void should_be_valid_if_using_service_discovery_and_no_host_and_ports()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = "/test",
|
||||
ServiceName = "Lads"
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsValid())
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void should_be_valid_re_route_using_host_and_port_and_paths()
|
||||
{
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = "/test",
|
||||
DownstreamHostAndPorts = new List<FileHostAndPort>
|
||||
{
|
||||
new FileHostAndPort
|
||||
{
|
||||
Host = "localhost",
|
||||
Port = 5000
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsValid())
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void should_be_valid_if_specified_authentication_provider_is_registered()
|
||||
{
|
||||
const string key = "JwtLads";
|
||||
|
||||
var fileReRoute = new FileReRoute
|
||||
{
|
||||
DownstreamPathTemplate = "/test",
|
||||
UpstreamPathTemplate = "/test",
|
||||
AuthenticationOptions = new FileAuthenticationOptions
|
||||
{
|
||||
AuthenticationProviderKey = key
|
||||
},
|
||||
DownstreamHostAndPorts = new List<FileHostAndPort>
|
||||
{
|
||||
new FileHostAndPort
|
||||
{
|
||||
Host = "localhost",
|
||||
Port = 5000
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
this.Given(_ => GivenThe(fileReRoute))
|
||||
.And(_ => GivenAnAuthProvider(key))
|
||||
.When(_ => WhenIValidate())
|
||||
.Then(_ => ThenTheResultIsValid())
|
||||
.BDDfy();
|
||||
}
|
||||
|
||||
private void GivenAnAuthProvider(string key)
|
||||
{
|
||||
var schemes = new List<AuthenticationScheme>
|
||||
{
|
||||
new AuthenticationScheme(key, key, typeof(FakeAutheHandler))
|
||||
};
|
||||
|
||||
_authProvider
|
||||
.Setup(x => x.GetAllSchemesAsync())
|
||||
.ReturnsAsync(schemes);
|
||||
}
|
||||
|
||||
private void ThenTheResultIsValid()
|
||||
{
|
||||
_result.IsValid.ShouldBeTrue();
|
||||
}
|
||||
|
||||
private void GivenThe(FileReRoute reRoute)
|
||||
{
|
||||
_reRoute = reRoute;
|
||||
}
|
||||
|
||||
private void WhenIValidate()
|
||||
{
|
||||
_result = _validator.Validate(_reRoute);
|
||||
}
|
||||
|
||||
private void ThenTheResultIsInvalid()
|
||||
{
|
||||
_result.IsValid.ShouldBeFalse();
|
||||
}
|
||||
|
||||
private void ThenTheErrorsContains(string expected)
|
||||
{
|
||||
_result.Errors.ShouldContain(x => x.ErrorMessage == expected);
|
||||
}
|
||||
|
||||
class FakeAutheHandler : IAuthenticationHandler
|
||||
{
|
||||
public Task InitializeAsync(AuthenticationScheme scheme, HttpContext context)
|
||||
{
|
||||
throw new System.NotImplementedException();
|
||||
}
|
||||
|
||||
public Task<AuthenticateResult> AuthenticateAsync()
|
||||
{
|
||||
throw new System.NotImplementedException();
|
||||
}
|
||||
|
||||
public Task ChallengeAsync(AuthenticationProperties properties)
|
||||
{
|
||||
throw new System.NotImplementedException();
|
||||
}
|
||||
|
||||
public Task ForbidAsync(AuthenticationProperties properties)
|
||||
{
|
||||
throw new System.NotImplementedException();
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user