#555 added some tests for this issue but struggling to replicate (#570)

* #555 added some tests for this issue but struggling to replicate

* #555 removed cmd=instance from service fabric code as someone who knows service fabric says its not needed
I

* #555 renamed test
This commit is contained in:
Tom Pallister
2018-08-25 12:33:49 +01:00
committed by GitHub
parent b0bdeb9402
commit 369fc5b7a4
4 changed files with 63 additions and 17 deletions

View File

@ -225,7 +225,7 @@
.And(x => x.GivenTheDownstreamRequestUriIs("http://localhost:19081"))
.And(x => x.GivenTheUrlReplacerWillReturn("/api/products/1"))
.When(x => x.WhenICallTheMiddleware())
.Then(x => x.ThenTheDownstreamRequestUriIs("http://localhost:19081/Ocelot/OcelotApp/api/products/1?cmd=instance"))
.Then(x => x.ThenTheDownstreamRequestUriIs("http://localhost:19081/Ocelot/OcelotApp/api/products/1"))
.BDDfy();
}
@ -255,7 +255,7 @@
.And(x => x.GivenTheDownstreamRequestUriIs("http://localhost:19081?Tom=test&laura=1"))
.And(x => x.GivenTheUrlReplacerWillReturn("/api/products/1"))
.When(x => x.WhenICallTheMiddleware())
.Then(x => x.ThenTheDownstreamRequestUriIs("http://localhost:19081/Ocelot/OcelotApp/api/products/1?Tom=test&laura=1&cmd=instance"))
.Then(x => x.ThenTheDownstreamRequestUriIs("http://localhost:19081/Ocelot/OcelotApp/api/products/1?Tom=test&laura=1"))
.BDDfy();
}

View File

@ -0,0 +1,21 @@
using System;
using System.Net.Http;
using Ocelot.Request.Middleware;
using Shouldly;
using Xunit;
namespace Ocelot.UnitTests.Request
{
public class DownstreamRequestTests
{
[Fact]
public void should_have_question_mark_with_question_mark_prefixed()
{
var httpRequestMessage = new HttpRequestMessage();
httpRequestMessage.RequestUri = new Uri("https://example.com/a?b=c");
var downstreamRequest = new DownstreamRequest(httpRequestMessage);
var result = downstreamRequest.ToHttpRequestMessage();
result.RequestUri.Query.ShouldBe("?b=c");
}
}
}