- 优化 Oracle IN :ids 值传入 IList 时报错;

This commit is contained in:
2881099 2022-08-02 13:45:05 +08:00
parent 034b4735f4
commit 66e6f39086
4 changed files with 88 additions and 75 deletions

View File

@ -753,8 +753,8 @@ namespace base_entity
}).Where(a => a.ConcurrentDictionarys.Length > 0).ToArray();
#region pgsql poco
// fsql.Aop.ParseExpression += (_, e) =>
// {
//fsql.Aop.ParseExpression += (_, e) =>
//{
// //解析 POCO Jsonb a.Customer.Name
// if (e.Expression is MemberExpression memExp)
// {
@ -787,27 +787,30 @@ namespace base_entity
// }
// }
// }
// };
//};
//void RegisterPocoType(Type pocoType)
//{
// var methodJsonConvertDeserializeObject = typeof(JsonConvert).GetMethod("DeserializeObject", new[] { typeof(string), typeof(Type) });
// var methodJsonConvertSerializeObject = typeof(JsonConvert).GetMethod("SerializeObject", new[] { typeof(object), typeof(JsonSerializerSettings) });
// var jsonConvertSettings = JsonConvert.DefaultSettings?.Invoke() ?? new JsonSerializerSettings();
// FreeSql.Internal.Utils.dicExecuteArrayRowReadClassOrTuple[typeof(Customer)] = true;
// FreeSql.Internal.Utils.dicExecuteArrayRowReadClassOrTuple[pocoType] = true;
// FreeSql.Internal.Utils.GetDataReaderValueBlockExpressionObjectToStringIfThenElse.Add((LabelTarget returnTarget, Expression valueExp, Expression elseExp, Type type) =>
// {
// return Expression.IfThenElse(
// Expression.TypeIs(valueExp, typeof(Customer)),
// Expression.TypeIs(valueExp, pocoType),
// Expression.Return(returnTarget, Expression.Call(methodJsonConvertSerializeObject, Expression.Convert(valueExp, typeof(object)), Expression.Constant(jsonConvertSettings)), typeof(object)),
// elseExp);
// });
// FreeSql.Internal.Utils.GetDataReaderValueBlockExpressionSwitchTypeFullName.Add((LabelTarget returnTarget, Expression valueExp, Type type) =>
// {
// if (type == typeof(Customer)) return Expression.Return(returnTarget, Expression.TypeAs(Expression.Call(methodJsonConvertDeserializeObject, Expression.Convert(valueExp, typeof(string)), Expression.Constant(type)), type));
// if (type == pocoType) return Expression.Return(returnTarget, Expression.TypeAs(Expression.Call(methodJsonConvertDeserializeObject, Expression.Convert(valueExp, typeof(string)), Expression.Constant(type)), type));
// return null;
// });
//}
// var seid = fsql.Insert(new SomeEntity
// {
//var seid = fsql.Insert(new SomeEntity
//{
// Customer = JsonConvert.DeserializeObject<Customer>(@"{
// ""Age"": 25,
// ""Name"": ""Joe"",
@ -816,10 +819,10 @@ namespace base_entity
// { ""OrderPrice"": 23, ""ShippingAddress"": ""Some address 2"" }
// ]
//}")
// }).ExecuteIdentity();
// var selist = fsql.Select<SomeEntity>().ToList();
//}).ExecuteIdentity();
//var selist = fsql.Select<SomeEntity>().ToList();
// var joes = fsql.Select<SomeEntity>()
//var joes = fsql.Select<SomeEntity>()
// .Where(e => e.Customer.Name == "Joe")
// .ToSql();
#endregion

View File

@ -733,15 +733,6 @@
<param name="modelBuilder"></param>
<returns></returns>
</member>
<member name="M:FreeSqlDbContextExtensions.ApplyConfigurationsFromAssembly(FreeSql.ICodeFirst,System.Reflection.Assembly,System.Func{System.Type,System.Boolean})">
<summary>
根据Assembly扫描所有继承IEntityTypeConfiguration&lt;T&gt;的配置类
</summary>
<param name="codeFirst"></param>
<param name="assembly"></param>
<param name="predicate"></param>
<returns></returns>
</member>
<member name="M:FreeSqlDbContextExtensions.CreateDbContext(IFreeSql)">
<summary>
创建普通数据上下文档对象
@ -800,14 +791,5 @@
<param name="that"></param>
<returns></returns>
</member>
<member name="M:Microsoft.Extensions.DependencyInjection.FreeSqlRepositoryDependencyInjection.AddFreeRepository(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{FreeSql.FluentDataFilter},System.Reflection.Assembly[])">
<summary>
批量注入 Repository可以参考代码自行调整
</summary>
<param name="services"></param>
<param name="globalDataFilter"></param>
<param name="assemblies"></param>
<returns></returns>
</member>
</members>
</doc>

View File

@ -1,5 +1,6 @@
using FreeSql.DataAnnotations;
using FreeSql.DataAnnotations;
using System;
using System.Collections.Generic;
using Xunit;
namespace FreeSql.Tests.Oracle
@ -55,6 +56,7 @@ namespace FreeSql.Tests.Oracle
var t5 = g.oracle.Ado.Query<dynamic>("select * from \"TB_TOPIC\"");
var t6 = g.oracle.Ado.Query<xxx>("select * from TB_TOPIC where id in :ids", new { ids = new[] { 1, 2, 3 } });
var t7 = g.oracle.Ado.Query<xxx>("select * from TB_TOPIC where id in :ids", new { ids = new List<int>(new[] { 1, 2, 3 }) });
}
[Fact]

View File

@ -2,6 +2,7 @@
using FreeSql.Internal.Model;
using Oracle.ManagedDataAccess.Client;
using System;
using System.Collections;
using System.Collections.Generic;
using System.Data.Common;
using System.Globalization;
@ -69,7 +70,32 @@ namespace FreeSql.Oracle
}
var ret = new OracleParameter { ParameterName = $":{name}" };
if (dbtype != null) ret.OracleDbType = dbtype.Value;
ret.Value = value;
if (value is IList valueList && value is Array == false && valueList.Count > 0)
{
var valueItemType = valueList[0]?.GetType();
if (valueItemType == typeof(int)) LocalSetListValue<int>();
else if (valueItemType == typeof(long)) LocalSetListValue<long>();
else if (valueItemType == typeof(short)) LocalSetListValue<short>();
else if (valueItemType == typeof(string)) LocalSetListValue<string>();
else if(valueItemType == typeof(Guid)) LocalSetListValue<Guid>();
else if (valueItemType == typeof(char)) LocalSetListValue<char>();
else if (valueItemType == typeof(bool)) LocalSetListValue<bool>();
else if (valueItemType == typeof(uint)) LocalSetListValue<uint>();
else if (valueItemType == typeof(ulong)) LocalSetListValue<ulong>();
else if (valueItemType == typeof(ushort)) LocalSetListValue<ushort>();
else if (valueItemType == typeof(decimal)) LocalSetListValue<decimal>();
else if (valueItemType == typeof(double)) LocalSetListValue<double>();
else if (valueItemType == typeof(float)) LocalSetListValue<float>();
else if (valueItemType == typeof(DateTime)) LocalSetListValue<DateTime>();
void LocalSetListValue<T>()
{
var valueCopy = new List<T>();
foreach (var valueItem in valueList) valueCopy.Add((T)Utils.GetDataReaderValue(valueItemType, valueItem));
value = valueCopy.ToArray();
}
}
ret.Value = value; //IList 赋值会报错
return ret;
});